ci: bump golangci-lint to v2.1 #4747
Conversation
| - uses: golangci/golangci-lint-action@v7 | ||
| with: | ||
| version: v2.0 | ||
| version: v2.1 |
There was a problem hiding this comment.
How about deleting this version definition?
There was a problem hiding this comment.
Assuming that if the version is not set, the latest one will be used, I don't think it's a good idea, because this will mean that over time our CI will break on its own (as newer golangci-lint will update or add more linters which may result in linter warnings).
By pinning the version, we avoid that breakage. When we update the version, we check that everything works fine, or fix the new issues found. In the meantime, the CI works.
It's basically the same argument as in commit b24fc9d
There was a problem hiding this comment.
Note though that I don't specify the patch version, meaning the latest patch version will be used (for example, when I specify v2.1, it will use v2.1.5 as of today). This is because I hope that the patch version bump won't introduce any breakage (while the minor version bump, such as switching from v2.2 to v2.3, might).
There was a problem hiding this comment.
Make sense, thanks your explanation.
(The current v2.1 release is v2.1.5 as of today). Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added
the
backport/1.3-done
3 participants
(The current v2.1 release is v2.1.5 as of today).