[1.2] make: use GO_VERSION=1 for release builds #4987
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have forgotten to bump GO_VERSION in our Dockerfile several times when doing releases from old release branches, leading to use using EOL'd Go versions for releases. We should just always use the latest version when building our release artefacts. Signed-off-by: Aleksa Sarai <[email protected]> (cherry picked from commit 83eca0f) Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
1.2-release-go-latest
branch
from
ce51fc1 to
e9261a5
Compare
Member
Author
|
Closing in favour of #4997. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4986. (Draft until merged.)
We have forgotten to bump GO_VERSION in our Dockerfile several times
when doing releases from old release branches, leading to use using
EOL'd Go versions for releases. We should just always use the latest
version when building our release artefacts.
Fixes #4969
Signed-off-by: Aleksa Sarai [email protected]