fix(shellcheck): remaining issues #8524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenwaite
approved these changes
Jun 26, 2025
|
is this ready to go out of draft mode? |
|
@bradymiller I wanted to resolve #8522 first before making this mergeable. Otherwise it won't actually resolve the remaining issues contrib/util/restore has the lion's share of shellcheck issues in the repo, and many of them would need to be resolved manually, so if we can't remove that script, it'll be a little bit before we can get a green shellcheck badge. |
kojiromike
force-pushed
the
shellcheck-last-of-us
branch
from
84beb1f to
4dde36c
Compare
|
I gave in and resolved the shellcheck issues in contrib/util/restore even though I don't think we can know if it's being used. |
bradymiller
approved these changes
Jul 1, 2025
|
hi @kojiromike , thanks for rehabilitating that script. looks good. bringing in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This should resolve the remaining shellcheck findings after #8522 and #8523
Changes proposed in this pull request:
findwhen globs will do the trick.Does your code include anything generated by an AI Engine? No