Feature/color temperature row crash guard#1133
Merged
Conversation
Guard against NaN propagation when min/max temperature values produce a zero-span range. Extract math into testable ColorTemperatureRowMath and replace stride-based gradient generation with an integer-step approach that is safe when the span is zero. Signed-off-by: Tim Mueller-Seydlitz <timbms@gmail.com>
Signed-off-by: Tim Mueller-Seydlitz <timbms@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is bug reported via Crashlytics:
Summary
CustomSliderViewwhenminValue == maxValueproduces a zero-span range, causing.position(x: NaN)to crash SwiftUI's layout engine duringpreferredLayoutAttributesFittingstride(from:through:by: 0)in gradient generation with an integer-step approach safe for zero spansColorTemperatureRowMathenum with unit tests covering degenerate range, mired conversion, server value fallback, and fraction clampingTest plan
ColorTemperatureRowMathTestspasses (normalizedRange fallback, mired conversion, server value fallback, degenerate fraction, gradient bounds)