Merged
Conversation
TAKeanice
force-pushed
the
notification_and_command_improvements
branch
from
efd845c to
a13cf7a
Compare
3 tasks
navigate to subpage in sitemap and allow no parameters in rule call fixes #978 Signed-off-by: Tassilo Karge <tassilo.karge@web.de>
TAKeanice
force-pushed
the
notification_and_command_improvements
branch
2 times, most recently
from
6b20b40 to
7fac6ec
Compare
3 tasks
Contributor
|
LGTM |
Contributor
Author
|
@digitaldan lgty, too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Navigate to subpage in sitemap and allow no parameters in rule call
@timbms this is partially still on the non-swift version of the SitemapViewController, but I think this is something you could add as tests for your new view controller: When a user clicks a notification action like
ui:/basicui/app?w=0001&sitemap=uicomponents_page_6d9f3ab29d, he previously only reached the sitemap, but not the selected page (w=0001).The other improvement is that rule calls like
rule:do_something:-can be rephrased torule:do_somethingwhich is more natural than the workaround to have some string as parameters so the parsing does not go wrong.