Improve the handling for f7-icons on Apple Watch and implement static icon#980
Merged
Improve the handling for f7-icons on Apple Watch and implement static icon#980
Conversation
Signed-off-by: Tim Mueller-Seydlitz <timbms@gmail.com>
timbms
changed the title
Signed-off-by: Tim Mueller-Seydlitz <timbms@gmail.com>
timbms
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves f7-icons handling on Apple Watch by implementing static icon support and fixing interface style detection. The changes ensure proper icon color handling and add Apple Watch-specific dark mode detection.
- Enhanced icon endpoint to support static icon parameter
- Fixed interface style detection for watchOS to always return dark mode
- Updated icon color handling from string "white" to hex "#FFFFFF" format
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| openHABWatch/Views/Utils/PreviewConstants.swift | Added new test widget with f7:alarm icon for testing |
| openHABWatch/Views/Utils/IconView.swift | Updated icon color format and added staticIcon parameter support |
| openHABWatch/Model/AppSettings.swift | Added convenience initializer for testing purposes |
| openHAB/OpenHABSitemapViewController.swift | Updated icon endpoint call to include staticIcon parameter |
| OpenHABCore/Sources/OpenHABCore/Util/UIColorExtension.swift | Fixed interface style detection for watchOS and improved iOS logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.