8353950: Clipboard interaction on Windows is unstable #24614
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Test passed even without the fix on macOS. If yes, then I think you should restrict the test to run only on required platforms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| /* | ||
| * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| /* | ||
| @test | ||
| @bug 8332271 | ||
| @summary tests that concurrent access to the clipboard does not crash the JVM | ||
| @key headful | ||
| @requires (os.family == "windows") | ||
| @run main ConcurrentClipboardAccessTest | ||
| */ | ||
| import java.awt.Toolkit; | ||
| import java.awt.datatransfer.Clipboard; | ||
| import java.awt.datatransfer.DataFlavor; | ||
|
|
||
| public class ConcurrentClipboardAccessTest { | ||
|
|
||
| public static void main(String[] args) { | ||
| Thread clipboardLoader1 = new Thread(new ClipboardLoader()); | ||
| clipboardLoader1.setDaemon(true); | ||
| clipboardLoader1.start(); | ||
| Thread clipboardLoader2 = new Thread(new ClipboardLoader()); | ||
| clipboardLoader2.setDaemon(true); | ||
| clipboardLoader2.start(); | ||
| long start = System.currentTimeMillis(); | ||
| while (true) { | ||
| try { | ||
| Thread.sleep(1000); | ||
| } catch (InterruptedException ignored) { | ||
| } | ||
| long now = System.currentTimeMillis(); | ||
| if ((now - start) > (10L * 1000L)) { | ||
| break; | ||
| } | ||
| } | ||
| // Test is considered successful if the concurrent repeated reading | ||
| // from clipboard succeeds for the allotted time and the JVM does not | ||
| // crash. | ||
| System.out.println("Shutdown normally"); | ||
| } | ||
|
|
||
| public static class ClipboardLoader implements Runnable { | ||
|
|
||
| @Override | ||
| public void run() { | ||
| final Clipboard systemClipboard = Toolkit.getDefaultToolkit().getSystemClipboard(); | ||
| while (true) { | ||
|
There was a problem hiding this comment. will this cause the test to run until timeout if the thread isn't interrupted? There was a problem hiding this comment. Valid point. Adjusted test to use daemon threads for the concurrent access tests. I reran the tests on the baseline JDK and after the changes to verify the findings from #24614 (comment). Did not notice this as the jtreg harness indeed seems to terminate the JVM and not report that as a failure, tested now also manually (without jtreg). |
||
| try { | ||
| if (systemClipboard.isDataFlavorAvailable(DataFlavor.stringFlavor)) { | ||
| systemClipboard.getData(DataFlavor.stringFlavor); | ||
| } | ||
| } catch (Exception ignored) { | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help me understand why this is better? Seems odd that the try/finally block has
closeClipboardin the finally block but theopenClipboardwas moved out of the try.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before the change the call order was inconsistent:
ClipboardTransferable: one call,openClipboardis called before thetry-blockWClipboard: one call withopenClipboardbefore thetry-block, one call withopenClipboardas first statement in thetry-blockSunClipboard: three calls withopenClipboardas first statement inside thetry-blockI unified these so that in all cases
openClipboardis called as the last statement before the try-block. The assumption is, that only ifopenClipboardsucceeds (does not raise an exception), callingcloseClipboardmakes sense.