8358094: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java still times out after JDK-8357282

[alexmenkov]

The test intermittently times out due to deadlock between 2 monitors: one monitor is JVMTI raw monitor used by agents, another is in Java (nsk_jvmti_aod_disableEventAndFinish does upcall) See JBS issue for details.
The fix updates agents to exit raw monitors before upcall.

Testing: no failures in 1000 runs

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358094: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java still times out after JDK-8357282 (Bug - P4)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Chris Plummer (@plummercj - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25684/head:pull/25684
$ git checkout pull/25684

Update a local copy of the PR:
$ git checkout pull/25684
$ git pull https://git.openjdk.org/jdk.git pull/25684/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25684

View PR using the GUI difftool:
$ git pr show -t 25684

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25684.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358094: Test vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java still times out after JDK-8357282

Reviewed-by: sspitsyn, cjplummer, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 38b877e: 8358294: Remove unnecessary GenAlignment
• 8f487d2: 8358577: Test serviceability/jvmti/thread/GetCurrentContendedMonitor/contmon01/contmon01.java failed: unexpexcted monitor object
• 500a3a2: 8358799: Refactor os::jvm_path()
• ... and 24 more: https://git.openjdk.org/jdk/compare/026975a1aa290613934ae421bbc56326627bad8d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1d74ff49)

[sspitsyn]

Looks good.

[alexmenkov]

/integrate

[openjdk]

Going to push as commit b3f5608.
Since your change was applied there have been 84 commits pushed to the master branch:

• ee35f63: 8359373: Split stubgen initial blob into pre and post-universe blobs
• 12a0dd0: 8358738: AOT cache created without graal jit should not be used with graal jit
• 366650a: 8355556: JVM crash because archived method handle intrinsics are not restored
• ... and 81 more: https://git.openjdk.org/jdk/compare/026975a1aa290613934ae421bbc56326627bad8d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit b3f5608.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.