Skip to content

8358617: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails with 403 due to system proxies #25692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kieran-farrell
Copy link
Contributor

@kieran-farrell kieran-farrell commented Jun 9, 2025

Intermittent failures have been seen with HttpURLConnectionExpectContinueTest on macOS possibly due to the test using the host systems proxy configurations.

Failures seen on JDK11 and JDK17 but adding no proxy conifguration to other JDK versions as a preventative measure.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358617: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails with 403 due to system proxies (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25692/head:pull/25692
$ git checkout pull/25692

Update a local copy of the PR:
$ git checkout pull/25692
$ git pull https://git.openjdk.org/jdk.git pull/25692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25692

View PR using the GUI difftool:
$ git pr show -t 25692

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25692.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2025

👋 Welcome back kieran-farrell! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@kieran-farrell This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358617: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails with 403 due to system proxies

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • cae1fd3: 8357632: CDS test failures on static JDK
  • eb8ee8b: 8358731: Remove jdk.internal.access.JavaAWTAccess.java
  • 2103dc1: 8358452: JNI exception pending in Java_sun_awt_screencast_ScreencastHelper_remoteDesktopKeyImpl of screencast_pipewire.c:1214 (ID: 51119)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 9, 2025
@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@kieran-farrell The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 9, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 9, 2025
@kieran-farrell
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 9, 2025
@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@kieran-farrell
Your change (at version c78ddbd) is now ready to be sponsored by a Committer.

@dfuch
Copy link
Member

dfuch commented Jun 9, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

Going to push as commit a377773.
Since your change was applied there have been 3 commits pushed to the master branch:

  • cae1fd3: 8357632: CDS test failures on static JDK
  • eb8ee8b: 8358731: Remove jdk.internal.access.JavaAWTAccess.java
  • 2103dc1: 8358452: JNI exception pending in Java_sun_awt_screencast_ScreencastHelper_remoteDesktopKeyImpl of screencast_pipewire.c:1214 (ID: 51119)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 9, 2025
@openjdk openjdk bot closed this Jun 9, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 9, 2025
@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@dfuch @kieran-farrell Pushed as commit a377773.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kieran-farrell
Copy link
Contributor Author

/backport :jdk25

@openjdk
Copy link

openjdk bot commented Jun 10, 2025

@kieran-farrell To use the /backport command, you need to be in the OpenJDK census and your GitHub account needs to be linked with your OpenJDK username (how to associate your GitHub account with your OpenJDK username).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net [email protected]
Development

Successfully merging this pull request may close these issues.

2 participants