-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8359114: [s390x] Add z17 detection code #25718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back mmatti-sw! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@mmatti-sw The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
I crashed JVM manually and in the hs_err file I see that z17 is detected properly;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@RealLucy would you provide 2nd review ?
@RealLucy could you please provide the much needed 2nd review? |
@theRealAph could you please provide the much needed 2nd review? |
Add support to detect the new generation of Z machine (z17).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25718/head:pull/25718
$ git checkout pull/25718
Update a local copy of the PR:
$ git checkout pull/25718
$ git pull https://git.openjdk.org/jdk.git pull/25718/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25718
View PR using the GUI difftool:
$ git pr show -t 25718
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25718.diff
Using Webrev
Link to Webrev Comment