Skip to content

8359114: [s390x] Add z17 detection code #25718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mmatti-sw
Copy link
Contributor

@mmatti-sw mmatti-sw commented Jun 10, 2025

Add support to detect the new generation of Z machine (z17).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8359114: [s390x] Add z17 detection code (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25718/head:pull/25718
$ git checkout pull/25718

Update a local copy of the PR:
$ git checkout pull/25718
$ git pull https://git.openjdk.org/jdk.git pull/25718/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25718

View PR using the GUI difftool:
$ git pr show -t 25718

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25718.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2025

👋 Welcome back mmatti-sw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8359114 8359114: [s390x] Add z17 detection code Jun 10, 2025
@openjdk
Copy link

openjdk bot commented Jun 10, 2025

@mmatti-sw The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mmatti-sw mmatti-sw marked this pull request as ready for review June 10, 2025 12:59
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2025

Webrevs

@offamitkumar
Copy link
Member

I crashed JVM manually and in the hs_err file I see that z17 is detected properly;

CPU: total 64 (initial active 64) system-z, g11-z17, ldisp_fast, extimm, pcrel_load/store, cmpb, cond_load/store, interlocked_update, txm, vectorinstr, instrext2, venh1, instrext3, venh2,bear_enh, sort_enh, nnpa_assist, storage_key_removal, vpack_decimal_enh, concurrent_function, out-of-support_as_of_tbd, aes128, aes192, aes256, sha1, sha256, sha512, ghash

Copy link
Member

@offamitkumar offamitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RealLucy would you provide 2nd review ?

@mmatti-sw
Copy link
Contributor Author

@RealLucy could you please provide the much needed 2nd review?

@mmatti-sw
Copy link
Contributor Author

@theRealAph could you please provide the much needed 2nd review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants