-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8360042: GHA: Bump MSVC to 14.44 #25912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Great, I can see that new runner image does not like
Given that new runner image would eventually deploy everywhere, this IMO leaves us with no choice but to do the |
Looks like it cannot find a C compiler on
FWIW,
|
@vieiro, please read this comment: #25912 (comment) -- we are in transient state. |
See the bug for extended details about this little mess.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25912/head:pull/25912
$ git checkout pull/25912
Update a local copy of the PR:
$ git checkout pull/25912
$ git pull https://git.openjdk.org/jdk.git pull/25912/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25912
View PR using the GUI difftool:
$ git pr show -t 25912
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25912.diff
Using Webrev
Link to Webrev Comment