Skip to content

8360042: GHA: Bump MSVC to 14.44 #25912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 20, 2025

See the bug for extended details about this little mess.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25912/head:pull/25912
$ git checkout pull/25912

Update a local copy of the PR:
$ git checkout pull/25912
$ git pull https://git.openjdk.org/jdk.git pull/25912/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25912

View PR using the GUI difftool:
$ git pr show -t 25912

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25912.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@shipilev
Copy link
Member Author

shipilev commented Jun 20, 2025

Great, I can see that new runner image does not like 14.43. So we are in weird spot at the moment:

  • Old runner image works with 14.43, fails with 14.44
  • New runner image fails with 14.43, works with 14.44
  • Old -> new runner image is currently deploying. About 1/4 of jobs I have seen still get the old runner image at the moment of writing.

Given that new runner image would eventually deploy everywhere, this IMO leaves us with no choice but to do the 14.44 switch now. On the up-side, compared to 14.43, 14.44 is actually claimed to be available by runner docs. With 14.43, we are playing with fire anyway.

@shipilev shipilev marked this pull request as ready for review June 20, 2025 09:02
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 20, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2025

Webrevs

@vieiro
Copy link

vieiro commented Jun 20, 2025

Looks like it cannot find a C compiler on windows-x64...

[...]
2025-06-20T08:34:28.2275609Z configure: Using default toolchain microsoft (Microsoft Visual Studio)
2025-06-20T08:34:28.4899994Z configure: Found Visual Studio installation at /c/progra~1/micros~2/2022/Enterprise using well-known name
2025-06-20T08:34:28.5299183Z configure: Found Microsoft Visual Studio 2022
2025-06-20T08:34:28.5300257Z configure: Trying to extract Visual Studio environment variables for x86_64
2025-06-20T08:34:28.5301467Z configure: using /c/progra~1/micros~2/2022/Enterprise/vc/auxiliary/build/vcvars64.bat 
2025-06-20T08:34:30.0458930Z configure: Setting extracted environment variables for x86_64
2025-06-20T08:34:30.3769850Z fixpath: warning: Path '/usr/local/bin' does not exist
2025-06-20T08:34:32.5499412Z fixpath: warning: Path '/usr/local/bin' does not exist
2025-06-20T08:34:35.7021325Z checking that Visual Studio variables have been correctly extracted... ok
2025-06-20T08:34:35.7345790Z checking for cl... [not found]
2025-06-20T08:34:35.7347978Z configure: error: Could not find a C compiler. 
2025-06-20T08:34:36.0019320Z configure exiting with result code 1
[...]

FWIW, 14.43 seems to be working fine for JDK11 with the windows-2022 / 14.43 combo:

2025-06-19T09:38:02.7046848Z configure: Using default toolchain microsoft (Microsoft Visual Studio)
2025-06-19T09:38:04.0725116Z configure: Found Visual Studio installation at /c/progra~1/micros~2/2022/Enterprise using well-known name
2025-06-19T09:38:04.1167106Z configure: Found Microsoft Visual Studio 2022
2025-06-19T09:38:04.1168531Z configure: Trying to extract Visual Studio environment variables for x86_64
2025-06-19T09:38:04.1170307Z configure: using /c/progra~1/micros~2/2022/Enterprise/vc/auxiliary/build/vcvarsx86_amd64.bat 
2025-06-19T09:38:05.5593722Z configure: Setting extracted environment variables for x86_64
2025-06-19T09:38:11.3981042Z checking that Visual Studio variables have been correctly extracted... ok
2025-06-19T09:38:11.7820392Z checking for cl... $FIXPATH /c/progra~1/micros~2/2022/enterp~1/vc/tools/msvc/1443~1.348/bin/hostx86/x64/cl.exe
2025-06-19T09:38:11.7830069Z checking resolved symbolic links for CC... no symlink
2025-06-19T09:38:12.0841912Z configure: Using microsoft C compiler version 19.43.34808 [Microsoft (R) C/C++ Optimizing Compiler Version 19.43.34808 for x64]
2025-06-19T09:38:20.8009463Z checking whether the C compiler works... yes
2025-06-19T09:38:20.8010308Z checking for C compiler default output file name... conftest.exe
2025-06-19T09:38:21.0792832Z checking for suffix of executables... .exe

@shipilev
Copy link
Member Author

@vieiro, please read this comment: #25912 (comment) -- we are in transient state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants