8382043: Add missing @Override annotations in "javax.print.attribute" package#30688
8382043: Add missing @Override annotations in "javax.print.attribute" package#30688mrserb wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back serb! A progress list of the required criteria for merging this PR into |
|
@mrserb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 143 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
This patch adds missing
@Overrideannotations to methods in thejavax.print.attributepackage that override methods from a superclass or interface.Only source annotations are added; there are no behavioral changes.
The previous patch for
com.sun.beanscan be found here: #27887.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30688/head:pull/30688$ git checkout pull/30688Update a local copy of the PR:
$ git checkout pull/30688$ git pull https://git.openjdk.org/jdk.git pull/30688/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30688View PR using the GUI difftool:
$ git pr show -t 30688Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30688.diff
Using Webrev
Link to Webrev Comment