Skip to content

8382043: Add missing @Override annotations in "javax.print.attribute" package#30688

Open
mrserb wants to merge 1 commit intoopenjdk:masterfrom
mrserb:JDK-8382043
Open

8382043: Add missing @Override annotations in "javax.print.attribute" package#30688
mrserb wants to merge 1 commit intoopenjdk:masterfrom
mrserb:JDK-8382043

Conversation

@mrserb
Copy link
Copy Markdown
Member

@mrserb mrserb commented Apr 11, 2026

This patch adds missing @Override annotations to methods in the javax.print.attribute package that override methods from a superclass or interface.
Only source annotations are added; there are no behavioral changes.

The previous patch for com.sun.beans can be found here: #27887.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8382043: Add missing @Override annotations in "javax.print.attribute" package (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30688/head:pull/30688
$ git checkout pull/30688

Update a local copy of the PR:
$ git checkout pull/30688
$ git pull https://git.openjdk.org/jdk.git pull/30688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30688

View PR using the GUI difftool:
$ git pr show -t 30688

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30688.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 11, 2026

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 11, 2026

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8382043: Add missing @Override annotations in "javax.print.attribute" package

Reviewed-by: dmarkov, azvegint, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 143 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Apr 11, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 11, 2026

@mrserb The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mrserb mrserb marked this pull request as ready for review April 14, 2026 02:19
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 14, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 14, 2026

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 14, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 16, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: client. This can be overridden with the /reviewers command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

4 participants