-
Notifications
You must be signed in to change notification settings - Fork 802
[Feature] Support progressDeadlineSeconds for CloneSet #2037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Feature] Support progressDeadlineSeconds for CloneSet #2037
Conversation
Signed-off-by: Saurav Teli <[email protected]>
-e Signed-off-by: Saurav Teli <[email protected]>
@fromsaurav: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Saurav Teli <[email protected]> -e Signed-off-by: Saurav Teli <[email protected]>
a5862ee
to
731e926
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2037 +/- ##
==========================================
- Coverage 43.78% 43.66% -0.12%
==========================================
Files 316 316
Lines 31617 31703 +86
==========================================
Hits 13842 13842
- Misses 16378 16462 +84
- Partials 1397 1399 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@fromsaurav thanks for your contribution to OpenKruise. However this issue is marked as the project for LFX mentorship term2, so we will accept the patch only if your application to the mentorship project is accepted. You can get familiar with OpenKruise with other issues that is not part of LFX mentorship program |
@furykerry got that, thank you! |
[Feature] Support progressDeadlineSeconds for CloneSet
I. Describe what this PR does
This PR adds support for
progressDeadlineSeconds
to CloneSet, similar to what Kubernetes Deployments offer. This feature helps users understand the progress of CloneSet rollouts by adding a condition to indicate when an update is stuck.II. Does this pull request fix one issue?
Fixes #2006
III. Describe how to verify it
progressDeadlineSeconds
specifiedProgressDeadlineExceeded
conditionIV. Special notes for reviews
This implementation follows the same pattern as Kubernetes Deployments for tracking progress deadlines. The design aligns with the existing CloneSet architecture while adopting proven patterns from core Kubernetes.
What type of PR is this?
/kind feature
What does this PR do?
This PR adds support for
progressDeadlineSeconds
to CloneSet, similar to what Kubernetes Deployments offer. This feature helps users understand the progress of CloneSet rollouts by adding a condition to indicate when an update is stuck.Features implemented:
progressDeadlineSeconds
field to CloneSetSpecWhich issue(s) this PR fixes:
Fixes #2006
Testing done:
Special notes for your reviewer:
This implementation follows the same pattern as Kubernetes Deployments for tracking progress deadlines.