-
Notifications
You must be signed in to change notification settings - Fork 802
feat: Enhance error messages in vertical scaling implementation #2051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2051 +/- ##
==========================================
- Coverage 43.78% 43.77% -0.01%
==========================================
Files 316 316
Lines 31617 31620 +3
==========================================
Hits 13842 13842
- Misses 16378 16380 +2
- Partials 1397 1398 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hello, @abhi0324 . Please sign off your commit. You can refer to the following link for more details: https://github.com/openkruise/kruise/pull/2051/checks?check_run_id=42660065552 |
Signed-off-by: Abhiswant Chaudhary <[email protected]>
Hi @ABNER-1 , thank you for the heads-up! The DCO check has passed, and the commit is signed off. Please let me know if anything else needs to be updated. |
Signed-off-by: Abhiswant Chaudhary <[email protected]>
Signed-off-by: Abhiswant Chaudhary <[email protected]>
/lgtm |
Ⅰ. Describe what this PR does
This PR enhances error messages in the vertical scaling implementation (pkg/util/inplaceupdate/inplace_update_vertical.go) to provide more context and helpful information for developers. It improves all error messages with detailed explanations, expected formats, and troubleshooting hints without changing any functionality.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
This PR only improves error message text without modifying any functional code. Examples of improvements: