Skip to content

fix: bypass next tag cache when there are no tags to check#988

Merged
vicb merged 2 commits intomainfrom
vicb/tag-cache-empty
Oct 1, 2025
Merged

fix: bypass next tag cache when there are no tags to check#988
vicb merged 2 commits intomainfrom
vicb/tag-cache-empty

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Oct 1, 2025

Before this PR hasBeenRevalidated might be called with an empty tag list.

However we can early return false in this case

@vicb vicb requested a review from conico974 October 1, 2025 07:46
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 1, 2025

🦋 Changeset detected

Latest commit: b9e64fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Oct 1, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@988

commit: b9e64fb

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 1, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 28.22% 2823 / 10002
🔵 Statements 28.22% 2823 / 10002
🔵 Functions 52.5% 147 / 280
🔵 Branches 75.94% 704 / 927
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/utils/cache.ts 81.69% 70.37% 100% 81.69% 14-15, 19-20, 22-23, 27, 40-41, 49-50, 69-70
Generated in workflow #1519 for commit b9e64fb by the Vitest Coverage Report Action

@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Oct 1, 2025

Thanks for the review Nico!

@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Oct 1, 2025

Oops, I need to update the tests...

@vicb vicb merged commit 4a11747 into main Oct 1, 2025
3 checks passed
@vicb vicb deleted the vicb/tag-cache-empty branch October 1, 2025 10:17
@github-actions github-actions Bot mentioned this pull request Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants