replace NEXT_BUILD_ID with OPEN_NEXT_BUILD_ID

[edmundhung]

This matches the changes in opennextjs/opennextjs-aws#1144 to deprecate the NEXT_BUILD_ID environment variable in favor of OPEN_NEXT_BUILD_ID.

[changeset-bot]

🦋 Changeset detected

Latest commit: 062514a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@opennextjs/cloudflare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@1208

commit: 062514a

[alex-all3dp]

@edmundhung @james-elicx is this the fix for opennextjs/opennextjs-aws#1136 and #1183 respectively? Does it require any changes on the user's side or will getDeploymentId() already return OPEN_NEXT_BUILD_ID once these changes are merged?

[james-elicx]

I believe some of the patches might need updating as well

[vicb]

I believe some of the patches might need updating as well

Do you have anything specific in mind ?

FYI I have just created a PR to aws and have further local commits that I will push after AWS is released but no update to patches yet.

Thanks

[james-elicx]

I believe some of the patches might need updating as well

Do you have anything specific in mind ?

FYI I have just created a PR to aws and have further local commits that I will push after AWS is released but no update to patches yet.

Thanks

I'm assuming these parts would want to reference the new variable:

opennextjs-cloudflare/packages/cloudflare/src/cli/build/patches/plugins/load-manifest.ts

Lines 70 to 72 in a2679bf

	if ($PATH.endsWith(".next/BUILD_ID")) {
	return process.env.NEXT_BUILD_ID;
	}

opennextjs-cloudflare/packages/cloudflare/src/cli/build/patches/plugins/next-server.ts

Lines 71 to 73 in a2679bf

	getBuildId($$$PARAMS) {
	return process.env.NEXT_BUILD_ID;
	}

[vicb]

I believe some of the patches might need updating as well

Do you have anything specific in mind ?
FYI I have just created a PR to aws and have further local commits that I will push after AWS is released but no update to patches yet.
Thanks

I'm assuming these parts would want to reference the new variable:

opennextjs-cloudflare/packages/cloudflare/src/cli/build/patches/plugins/load-manifest.ts

Lines 70 to 72 in a2679bf

	if ($PATH.endsWith(".next/BUILD_ID")) {
	return process.env.NEXT_BUILD_ID;
	}

opennextjs-cloudflare/packages/cloudflare/src/cli/build/patches/plugins/next-server.ts

Lines 71 to 73 in a2679bf

	getBuildId($$$PARAMS) {
	return process.env.NEXT_BUILD_ID;
	}

I believe not, this is Next code and behavior should not be altered.
@conico974 do you confirm?

[vicb]

@conico974 @edmundhung @james-elicx Could you please take a quick look at the PR. IMO it's good to go (I'll release AWS and use that after the changes here are validated).

[conico974]

I believe some of the patches might need updating as well

Do you have anything specific in mind ?
FYI I have just created a PR to aws and have further local commits that I will push after AWS is released but no update to patches yet.
Thanks

I'm assuming these parts would want to reference the new variable:

opennextjs-cloudflare/packages/cloudflare/src/cli/build/patches/plugins/load-manifest.ts

Lines 70 to 72 in a2679bf

	if ($PATH.endsWith(".next/BUILD_ID")) {
	return process.env.NEXT_BUILD_ID;
	}

opennextjs-cloudflare/packages/cloudflare/src/cli/build/patches/plugins/next-server.ts

Lines 71 to 73 in a2679bf

	getBuildId($$$PARAMS) {
	return process.env.NEXT_BUILD_ID;
	}

I believe not, this is Next code and behavior should not be altered. @conico974 do you confirm?

Yeah we don't want to modify that, that's also why I named the new env OPEN_NEXT_BUILD_ID instead

[vicb]

Thanks for the reviews @conico974 and @james-elicx !

[vicb]

Thanks for the PR @edmundhung !