Conversation
🦋 Changeset detectedLatest commit: 53e43d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
Author
|
@conico974 what I'm doing here is very close to Do you think that this API makes sense? or do you think that we should try to align things more? |
conico974
approved these changes
Feb 25, 2025
Collaborator
conico974
left a comment
conico974
left a comment
There was a problem hiding this comment.
LGTM, just few nit
Do you think that this API makes sense? or do you think that we should try to align things more?
Yeah i think it makes perfect sense, this is enough. If people needs more complex options they can just provide their own open-next.config.ts
vicb
reviewed
Feb 25, 2025
dario-piotrowicz
changed the title
defineConfig utilitydefineCloudflareConfig utility
dario-piotrowicz
force-pushed
the
dario/114/defineConfig
branch
4 times, most recently
from
b52ba04 to
70735e6
Compare
vicb
approved these changes
Feb 26, 2025
vicb
reviewed
Feb 26, 2025
vicb
reviewed
Feb 26, 2025
vicb
reviewed
Feb 26, 2025
dario-piotrowicz
force-pushed
the
dario/114/defineConfig
branch
from
a43210a to
541ba8c
Compare
james-elicx
reviewed
Feb 26, 2025
james-elicx
approved these changes
Feb 26, 2025
james-elicx
reviewed
Feb 26, 2025
vicb
reviewed
Feb 27, 2025
vicb
reviewed
Feb 27, 2025
vicb
reviewed
Feb 27, 2025
vicb
reviewed
Feb 27, 2025
vicb
reviewed
Feb 27, 2025
vicb
reviewed
Feb 27, 2025
vicb
approved these changes
Feb 27, 2025
this change adds a new `defineConfig` utility that developers can use in their `open-next.config.ts` file to easily generate a configuration compatible with the adapter
this change adds a new `defineConfig` utility that developers can use in their `open-next.config.ts` file to easily generate a configuration compatible with the adapter
Co-authored-by: Victor Berchet <victor@suumit.com>
Co-authored-by: James Anderson <james@eli.cx>
Co-authored-by: Victor Berchet <victor@suumit.com>
dario-piotrowicz
force-pushed
the
dario/114/defineConfig
branch
from
1ebc5ec to
77d2a25
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change adds a new
defineCloudflareConfigutility that developers can use in theiropen-next.config.tsfile to easily generate a configuration compatible with the adapterDocs PR: opennextjs/docs#84
resolves #114