patch node-module-loader dynamic require

[HyperKiko]

should fix #380

[changeset-bot]

🦋 Changeset detected

Latest commit: df638ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@opennextjs/cloudflare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vicb]

Thanks for the PR.

I added minor comments but what's this is really lacking is a test in e2e/pages-router. Can you please add one?

[HyperKiko]

Thanks for the PR.

I added minor comments but what's this is really lacking is a test in e2e/pages-router. Can you please add one?

i'm not quite sure how i'd go about doing that. should i just create a test that fetches the api route and checks that the response was successful?

[vicb]

i'm not quite sure how i'd go about doing that. should i just create a test that fetches the api route and checks that the response was successful?

That sounds great.
We have examples in the playground tests if needed.

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@431

commit: df638ff

[vicb]

Maybe you can also move the 2 patches in the same file as they are very closely related. It will probably allow to factor some code too.

[HyperKiko]

if you don't have any more comments could this get merged?

[vicb]

if you don't have any more comments could this get merged?

Have you tried the build of the adapter attached to this PR and can confirm it fixed your issue?

Thanks for your work on the fix!

[vicb]

If everything works as expected, please add a patch changeset (pnpm changeset and follow the prompt)

[vicb]

Use pnpm fix to format the coffee but it looks like there are legit errors to fix first

[HyperKiko]

Use pnpm fix to format the coffee but it looks like there are legit errors to fix first

should be fixed now, seems like it was because of yaml not being as generous with whitespace, could you rerun the checks/workflows? i'll test it on my app with pkg.pr.new

[vicb]

Use pnpm e2e to run the tests locally, formatting still looks off

[HyperKiko]

Use pnpm e2e to run the tests locally, formatting still looks off

should be good to go now. the issue was that patchCode parses as typescript instead of javascript, which slightly changes the output. i just modified the rule. not sure why that's the case, though, since it should always be parsing prebuilt code

[vicb]

Thanks!