Conversation
🦋 Changeset detectedLatest commit: 451c41c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
james-elicx
approved these changes
Mar 12, 2025
conico974
reviewed
Mar 12, 2025
Contributor
Author
|
Thanks James (I had to rebase because it has a dep on my previous PR) |
conico974
approved these changes
Mar 12, 2025
Collaborator
conico974
left a comment
conico974
left a comment
There was a problem hiding this comment.
LGTM, you did not add a changeset though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #442
While the patch is the same, the path to the patched file is different in Next14 (
next/dist/server/future/helpers/module-loader/node-module-loader.js). Update the patch to cover both Next14 (add test) and Next 15 (already tested)