Merged
Conversation
🦋 Changeset detectedLatest commit: d94c23b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
vicb
reviewed
Mar 22, 2025
vicb
reviewed
Mar 22, 2025
vicb
reviewed
Mar 22, 2025
vicb
approved these changes
Mar 22, 2025
Contributor
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
Nice!
A few nits related to naming
conico974
force-pushed
the
feat/double-sharding
branch
from
62994a5 to
0829f86
Compare
vicb
reviewed
Mar 24, 2025
Contributor
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
I think we should be careful with naming things correctly to ease later evolutions and maintenance of the code.
I think we have shards, replicas and DOs.
Each shards has a soft and hard variant.
Those variants are replicated to distinct DOs when enableShardReplication is true.
I added a few inline comments, let's iterate.
Thanks!
vicb
reviewed
Mar 24, 2025
vicb
reviewed
Mar 24, 2025
vicb
reviewed
Mar 24, 2025
vicb
reviewed
Mar 24, 2025
vicb
reviewed
Mar 24, 2025
vicb
reviewed
Mar 24, 2025
vicb
reviewed
Mar 24, 2025
vicb
reviewed
Mar 24, 2025
vicb
reviewed
Mar 25, 2025
vicb
approved these changes
Mar 25, 2025
Contributor
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
Cool, thanks a lot for the updates 🚀
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements sharding replication for the Durable Object tag cache.
Instead of being sharded only based on the tag, each shard will now also be replicated
This allow to scale way more (virtually infinitely)
A single tag could be read from any of the N random replicas associated with the tag shard.
On write we still need to write to every single replicas associated with this tag shard