Merged
Conversation
🦋 Changeset detectedLatest commit: 56dca94 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
force-pushed
the
feat/queue-cache
branch
from
366d593 to
e3f9be7
Compare
conico974
force-pushed
the
feat/queue-cache
branch
from
fc3c46d to
a3d5d7e
Compare
conico974
force-pushed
the
feat/queue-cache
branch
from
a3d5d7e to
48eb27f
Compare
vicb
reviewed
May 20, 2025
Contributor
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
Let's merge this for 1.1.
Could you please work on a doc PR when you have time to describe the Queue Cache and the options so that we can merge at the same time.
vicb
reviewed
May 20, 2025
vicb
reviewed
May 20, 2025
vicb
reviewed
May 20, 2025
vicb
reviewed
May 20, 2025
vicb
reviewed
May 20, 2025
conico974
force-pushed
the
feat/queue-cache
branch
from
48eb27f to
9842527
Compare
vicb
reviewed
May 20, 2025
Contributor
|
Doc in opennextjs/docs#156 |
vicb
reviewed
May 26, 2025
vicb
approved these changes
May 26, 2025
Contributor
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
LGTM
Let's add this to the next minor
Co-authored-by: Victor Berchet <victor@suumit.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Durable object queue should already be able to handle most situation, but there is a case where for a single route, while being stale, you reach the limits of what a single durable object is capable of handling.
For this kind of cases, adding cache in front will help (but in case of error between the worker and the durable object, revalidation may take more time to happen)
There is 1 other upgrade that we could do for this case: