fix: npm failing to pass args to wrangler#505
Merged
james-elicx merged 4 commits intomainfrom Mar 26, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 35e647f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
james-elicx
force-pushed
the
james/fix-npm-args
branch
from
4bd4db5 to
df62d4e
Compare
vicb
reviewed
Mar 26, 2025
vicb
approved these changes
Mar 26, 2025
Contributor
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
LGTM, would be nice to have some comment
james-elicx
force-pushed
the
james/fix-npm-args
branch
from
df62d4e to
56bc16d
Compare
Collaborator
Author
|
I re-jigged the implementation while you were reviewing @vicb, would you mind taking another look please? |
vicb
reviewed
Mar 26, 2025
vicb
approved these changes
Mar 26, 2025
james-elicx
commented
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another package manager inconsistency. npm and yarn both need
--to pass args to wrangler properly, whereas pnpm and bun will fail to pass args properly to wrangler if--is supplied...