Skip to content

fix a few windows path issues#599

Merged
vicb merged 2 commits intomainfrom
james/windows
May 14, 2025
Merged

fix a few windows path issues#599
vicb merged 2 commits intomainfrom
james/windows

Conversation

@james-elicx
Copy link
Copy Markdown
Collaborator

@james-elicx james-elicx commented Apr 22, 2025 •
edited
Loading

Changes:

  • Caches playwright browsers.
  • Fixes several path normalisation issues.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 22, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 765f765

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 22, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@599

commit: 765f765

@james-elicx james-elicx force-pushed the james/windows branch 21 times, most recently from 4ea8600 to a8b5cbe Compare April 27, 2025 19:12
@james-elicx james-elicx marked this pull request as ready for review April 27, 2025 19:43
@vicb
Copy link
Copy Markdown
Contributor

vicb commented Apr 30, 2025

I have squashed the commits and rebased on main

@james-elicx james-elicx force-pushed the james/windows branch 3 times, most recently from 00c63f7 to 3aa07ee Compare April 30, 2025 18:38
@james-elicx james-elicx force-pushed the james/windows branch 2 times, most recently from e2651b3 to 3583b25 Compare April 30, 2025 18:41
@james-elicx james-elicx changed the title run e2es on windows fix a few windows path issues Apr 30, 2025
@james-elicx james-elicx requested a review from vicb April 30, 2025 19:18
@vicb
Copy link
Copy Markdown
Contributor

vicb commented Apr 30, 2025

I was thinking about that earlier today, we have 3 choices:

  • drop windows specific code
  • merge the PR now knowing that we won't invest further in windows w/o WSL
  • keep the PR opened if someone wants to take over

Let's discuss during the next weekly?

@james-elicx
Copy link
Copy Markdown
Collaborator Author

james-elicx commented Apr 30, 2025

I don't think it makes sense to drop Windows-specific code - if someone wants to come along and fix it in the future then there will still be a decent starting point instead of starting from scratch.

It's just that we won't invest any time going forwards in ensuring new (or old) code supports Windows.

vicb
vicb approved these changes May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged.

Could you please rebase on main when you get a chance?

vicb
vicb approved these changes May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James 🙏

@vicb vicb merged commit 7b06a42 into main May 14, 2025
7 checks passed
@vicb vicb deleted the james/windows branch May 14, 2025 19:07
@workers-frameworks workers-frameworks mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb vicb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@james-elicx @vicb