fix: remote flag not working for preview command's cache population#888
fix: remote flag not working for preview command's cache population#888james-elicx merged 4 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: d0cff66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
Thanks for the fix @james-elicx @dario-piotrowicz could you please take a look as you worked on the remote bindings. |
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Looks good to me 🙂
Although, tangential to the changes here, long term I would say that ideally remote bindings should be used instead of running the worker with --remote (unless there's a benefit/reason to do so?)
I think the plan is to remove |
vicb
left a comment
vicb
left a comment
There was a problem hiding this comment.
@james-elicx I added a few minor comments.
The one most important thing is to add the "r" alias for "remote" IMO.
Thanks!
|
Sorry for the delay in the review, please see my comments. |
3 participants
When passing the
--remoteflag to ourpreviewcommand, it would fail to properly populate the cache due to not targeting the remote bindings and missing a--previewflag for Workers KV / D1.fixes #887
Changes:
Tested that cache population was working as expected with the following commands for the
d1-tag-nextexample:opennextjs-cloudflare preview --config wrangler.e2e.jsoncopennextjs-cloudflare preview --config wrangler.e2e.jsonc --remoteopennextjs-cloudflare deploy --config wrangler.e2e.jsonc