Conversation
🦋 Changeset detectedLatest commit: b27784b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
conico974
left a comment
conico974
left a comment
There was a problem hiding this comment.
Just some small little change needed and a few thing maybe to add as comment
| await kv.put(this.getCacheKey(tag), timeMs); | ||
| }) | ||
| ); | ||
| await purgeCacheByTags(tags); |
There was a problem hiding this comment.
This is already done in aws, we should not do it again here
There was a problem hiding this comment.
So I guess it should be removed from D1 and DO too?
There was a problem hiding this comment.
Not sure how/where this is done in aws though?
Can you point to the code?
There was a problem hiding this comment.
Nevermind I was wrong, but we should do it there https://github.com/opennextjs/opennextjs-aws/blob/23ed1df6b887526dc8b573c0ea099b4009b410ec/packages/open-next/src/adapters/cache.ts#L331-L333
There was a problem hiding this comment.
Before checking the length, right?
There was a problem hiding this comment.
Oh I see what you mean, we should implement a new method in the CDN invalidation.
So I guess this code is good to merge now (I'll add a TODO here and for D1 & DO).
(A follow-up I had was to only call purgeCacheByTags when there is a CDN invalidator so that we do not log errors when not).
I could create an issue in aws to add the method and reference it in this repo.
Do that sound good?
…che.ts Co-authored-by: conico974 <nicodorseuil@yahoo.fr>
Co-authored-by: conico974 <nicodorseuil@yahoo.fr>
|
Thanks for the review and feedback Nico! |
3 participants
No description provided.