Skip to content

Fix shell quoting on windows machines to avoid upload errors#976

Merged
vicb merged 3 commits intoopennextjs:mainfrom
rgembalik:feature/fix-shell-quoting-on-windows
Nov 6, 2025
Merged

Fix shell quoting on windows machines to avoid upload errors#976
vicb merged 3 commits intoopennextjs:mainfrom
rgembalik:feature/fix-shell-quoting-on-windows

Conversation

@rgembalik
Copy link
Copy Markdown
Contributor

Whenever page contains path with [...path] segments, upload fails on windows machine. This can be prevented by alternative escaping logic for windows.

I added necessary changes and to avoid any issues with non-windows machines, I put it into separate if (process.platform === "win32").

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 6, 2025

🦋 Changeset detected

Latest commit: 7cabdd5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Nov 6, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@976

commit: 7cabdd5

Copy link
Copy Markdown
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@vicb vicb merged commit 93f4c8a into opennextjs:main Nov 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants