Skip to content

Enable custom Serial Version UID #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2025
Merged

Conversation

yuri1969
Copy link
Contributor

@yuri1969 yuri1969 commented May 4, 2025

What's changed?

To be able to choose from 1, 1L, or any other value.

What's your motivation?

Codebases often go for the 1L value, so having an option to use that value is cool.

Anything in particular you'd like reviewers to focus on?

Unit test coverage, maybe?

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

To be able to choose from `1`, `1L`, or any other value.
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite May 4, 2025
@timtebeek timtebeek added enhancement New feature or request recipe labels May 4, 2025
@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite May 4, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/resources/META-INF/rewrite/examples.yml
    • lines 57-56
    • lines 634-633
    • lines 679-695
    • lines 1228-1247
    • lines 1280-1279
    • lines 2309-2308
    • lines 2324-2336
    • lines 3442-3453
    • lines 3467-3472

Copy link
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition here! Should help folks standardize if they had a certain preference.

@timtebeek timtebeek merged commit a682e11 into openrewrite:main May 4, 2025
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite May 4, 2025
@yuri1969 yuri1969 deleted the custom-uid branch May 4, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request recipe
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants