Handle static method calls when removing unnecessary explicit type arguments.

[JohannisK]

What's changed?

Adde rules to the removing unnecessary explicit type arguments recipe to deal with static method calls.

What's your motivation?

The recipe currently removes explicit type arguments from method calls that need it.

[JohannisK]

This change might be to simplistic, but when the enclosing is a method invocation:
We're dealing with GenericClass.<String>someTypedBuilder(String.class), and enclosing is GenericClass.<String>someTypedBuilder(String.class).build()

<String> is already kept and returned earlier if the argument of the method does not do type inference (e.g. it does not take Class<T> arg. If it does do type inference, the method is its own enclosing type.
E.G.
When GenericClass.<String>someTypedBuilder(String.class) returns a type inferred instance GenericClassBuild<String>,
GenericClass.<String>someTypedBuilder(String.class).build() should be the same as

GenericClassBuild<String> gcb = GenericClass.someTypedBuilder(String.class);
gcb.build();

and so the explicit generic type can be removed?

Please double check my logic

[JohannisK]

Assigning the returnType to enclosingType is a bit of an ugly way of forcing the existing code to remove explicit generic type information.
Maybe I should rename enclosingType to inferedType?

if (enclosingType != null && TypeUtils.isOfType(enclosingType, m.getMethodType().getReturnType())) {
    m = m.withTypeParameters(null);
}

if the return type of the method invocation is the same as the inferred type, the explicit type arguments may be removed?

[jevanlingen]

Maybe I should rename enclosingType to inferedType?

Yeah do that, that's way easier to understand if you read this recipe for the first time.

[JohannisK]

Done, leaving this open for @timtebeek to have this context when he reviews.

[github-actions]

Some suggestions could not be made:

• src/main/resources/META-INF/rewrite/examples.yml
  • lines 636-652
  • lines 698-697
  • lines 2311-2310
  • lines 2326-2338

[timtebeek]

Thanks for the fix here! Great to not make incorrect changes where we can avoid it.

[github-actions]

Some suggestions could not be made:

• src/main/resources/META-INF/rewrite/examples.yml
  • lines 474-473
  • lines 636-652
  • lines 698-697
  • lines 2311-2310
  • lines 2326-2338