Skip to content

fix bug in save query list #10028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: query_explore
Choose a base branch
from

Conversation

ruchidh
Copy link
Contributor

@ruchidh ruchidh commented Jul 1, 2025

Description

Saved query list fix

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ruchi Sharma <[email protected]>
Copy link
Contributor

github-actions bot commented Jul 1, 2025

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

github-actions bot commented Jul 1, 2025

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jul 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (query_explore@014b87b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ta/public/query/saved_query/saved_query_service.ts 0.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             query_explore   #10028   +/-   ##
================================================
  Coverage                 ?   59.94%           
================================================
  Files                    ?     4085           
  Lines                    ?   104135           
  Branches                 ?    16582           
================================================
  Hits                     ?    62422           
  Misses                   ?    37569           
  Partials                 ?     4144           
Flag Coverage Δ
Linux_1 27.89% <0.00%> (?)
Linux_2 41.63% <ø> (?)
Windows_1 27.90% <0.00%> (?)
Windows_2 41.61% <ø> (?)
Windows_3 39.29% <0.00%> (?)
Windows_4 29.39% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants