Update json5 dependency #6937
Merged
Update json5 dependency #6937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "chore". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
Signed-off-by: Simeon Widdis <[email protected]>
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "chore". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
The PR template says
|
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "chore". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
github-actions
bot
added
Skip-Changelog
74 tasks
This reverts commit 526e0bb. Signed-off-by: Simeon Widdis <[email protected]>
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "chore". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
github-actions
bot
added
failed changeset
Skip-Changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6937 +/- ##
==========================================
- Coverage 67.43% 67.42% -0.02%
==========================================
Files 3443 3443
Lines 67806 67806
Branches 11031 11031
==========================================
- Hits 45727 45717 -10
- Misses 19413 19423 +10
Partials 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BionIT
approved these changes
Jun 6, 2024
ZilongX
approved these changes
Jun 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
* Update json5 Signed-off-by: Simeon Widdis <[email protected]> * Update changelog Signed-off-by: Simeon Widdis <[email protected]> * Revert "Update changelog" This reverts commit 526e0bb. Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Simeon Widdis <[email protected]> Co-authored-by: Lu Yu <[email protected]> (cherry picked from commit 9674147) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
This one is tricky
Therefore we should never add resolution to json5 in the future. The change only impacts our dep and I compared. we only use stringfy from JSON5 in json5. Here is v1's stringfy https://github.com/json5/json5/blob/v1/src/stringify.js and here is v2's https://github.com/json5/json5/blob/v2/lib/stringify.js. Therefore, the change is good to me. |
BionIT
added a commit
that referenced
this pull request
Jun 6, 2024
* Update json5 * Update changelog * Revert "Update changelog" This reverts commit 526e0bb. --------- (cherry picked from commit 9674147) Signed-off-by: Simeon Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coming from downstream where we recently added json5 for a feature, our distribution build is failing due to an outdated json5 version used here. We could downgrade our dependency, but considering that the json5 changelog has no breaking changes for the core API, it seems more straightforward to update it here directly.
Issues Resolved
Resolves build failures in opensearch-project/dashboards-observability#1861.
Screenshot
N/A
Testing the changes
Trusting CI to catch any issues on this one; according to the json5 changelog this is a no-op.
Changelog
Check List
yarn test:jestyarn test:jest_integration