Skip to content

Added stats for phase results processors at search pipeline level #17559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Mar 9, 2025

Description

Adding stats for search phase result processor type. Today we do not collect any metric for this processor type, while for request and response processor types those metrics are collected and returned with the node level stats response.

Sample request, no changes there

GET /_nodes/stats/search_pipeline

sample response, section phase_results_processors is added with this PR:

        "XzOye699Q-SnVrFcJ-b8Tg": {
            "timestamp": 1741224352625,
            "name": "integTest-0",
            "transport_address": "127.0.0.1:9300",
            "host": "127.0.0.1",
            "ip": "127.0.0.1:9300",
            "roles": [
                "cluster_manager",
                "data",
                "ingest",
                "remote_cluster_client"
            ],
            "attributes": {
                "testattr": "test",
                "shard_indexing_pressure_enabled": "true"
            },
            "search_pipeline": {
                "total_request": {
                    "count": 240,
                    "time_in_millis": 547,
                    "current": 0,
                    "failed": 0
                },
                "total_response": {
                    "count": 0,
                    "time_in_millis": 0,
                    "current": 0,
                    "failed": 0
                },
                "pipelines": {
                    "nlp-min-max-arithmetic-search-pipeline": {
                        "request": {
                            "count": 240,
                            "time_in_millis": 547,
                            "current": 0,
                            "failed": 0
                        },
                        "response": {
                            "count": 0,
                            "time_in_millis": 0,
                            "current": 0,
                            "failed": 0
                        },
                        "request_processors": [],
                        "response_processors": [],
                        "phase_results_processors": [
                            {
                                "normalization-processor": {
                                    "type": "normalization-processor",
                                    "stats": {
                                        "count": 240,
                                        "time_in_millis": 545,
                                        "current": 0,
                                        "failed": 0
                                    }
                                }
                            }
                        ]
                    }
                }
            }
        }, 

Related Issues

#17558

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@martin-gaievski martin-gaievski force-pushed the add_stats_phase_results_processor branch from a16e3fe to ffeb095 Compare March 9, 2025 22:24
Copy link
Contributor

github-actions bot commented Mar 9, 2025

❌ Gradle check result for ffeb095: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ffeb095: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7bf703b: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7bf703b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for abc41be: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Apr 19, 2025
@martin-gaievski martin-gaievski force-pushed the add_stats_phase_results_processor branch 2 times, most recently from 7ee0aae to 398d60d Compare June 20, 2025 21:58
Copy link
Contributor

❌ Gradle check result for 791ab01: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@martin-gaievski martin-gaievski force-pushed the add_stats_phase_results_processor branch 3 times, most recently from 4410db9 to 3663ef6 Compare June 21, 2025 00:09
Copy link
Contributor

❌ Gradle check result for 3663ef6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@martin-gaievski martin-gaievski force-pushed the add_stats_phase_results_processor branch from 659d471 to 39d4be9 Compare June 21, 2025 02:38
Copy link
Contributor

❌ Gradle check result for 39d4be9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@martin-gaievski martin-gaievski force-pushed the add_stats_phase_results_processor branch from 39d4be9 to 019eb57 Compare June 23, 2025 00:26
Copy link
Contributor

❌ Gradle check result for 019eb57: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@martin-gaievski martin-gaievski force-pushed the add_stats_phase_results_processor branch from 019eb57 to 3a9ff77 Compare June 23, 2025 03:53
Copy link
Contributor

❌ Gradle check result for 3a9ff77: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jun 23, 2025
@martin-gaievski martin-gaievski force-pushed the add_stats_phase_results_processor branch from a5e5dfb to 71719e7 Compare June 23, 2025 17:56
Copy link
Contributor

❌ Gradle check result for 71719e7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Martin Gaievski <[email protected]>
@martin-gaievski martin-gaievski force-pushed the add_stats_phase_results_processor branch from 71719e7 to c590b83 Compare June 23, 2025 19:39
Copy link
Contributor

❌ Gradle check result for c590b83: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant