-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Pull-based Ingestion] disable push-API for indexing in ingestionEngine #17768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
server/src/main/java/org/opensearch/index/engine/IngestionEngine.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/engine/IngestionEngineTests.java
Outdated
Show resolved
Hide resolved
I think this should be a 4xx error code, not a 500, right? |
❕ Gradle check result for 04595e1: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17768 +/- ##
============================================
- Coverage 72.46% 72.40% -0.07%
+ Complexity 66502 66458 -44
============================================
Files 5408 5409 +1
Lines 308080 308192 +112
Branches 44720 44746 +26
============================================
- Hits 223239 223133 -106
- Misses 66536 66732 +196
- Partials 18305 18327 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
right, ideally it shall be 4xx to indicate client-side error. is it possible to catch the thrown exception and change error code somewhere? |
❌ Gradle check result for c97ee5b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
❌ Gradle check result for da32ad0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Yupeng Fu <[email protected]>
…ne (opensearch-project#17768) --------- Signed-off-by: Yupeng Fu <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
…ne (opensearch-project#17768) --------- Signed-off-by: Yupeng Fu <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
Description
The indexing API call will fail for ingestion engine. For example
returns
Related Issues
#16930
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.