Skip to content

Remove deprecated batch_size parameter from _bulk #17801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrross
Copy link
Member

@andrross andrross commented Apr 4, 2025

Related Issues

Resolves #14283

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross andrross added >breaking Identifies a breaking change. v3.0.0 Issues and PRs related to version 3.0.0 labels Apr 4, 2025
@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing labels Apr 4, 2025
Copy link
Contributor

github-actions bot commented Apr 4, 2025

✅ Gradle check result for b06dee1: SUCCESS

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.40%. Comparing base (2d42bd0) to head (b06dee1).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
...n/java/org/opensearch/action/bulk/BulkRequest.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17801      +/-   ##
============================================
+ Coverage     72.39%   72.40%   +0.01%     
- Complexity    66066    66092      +26     
============================================
  Files          5358     5358              
  Lines        306500   306490      -10     
  Branches      44409    44408       -1     
============================================
+ Hits         221888   221914      +26     
+ Misses        66474    66441      -33     
+ Partials      18138    18135       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mch2 mch2 merged commit 405586c into opensearch-project:main Apr 9, 2025
61 of 62 checks passed
@andrross andrross deleted the remove-batch-size-param-on-bulk branch April 9, 2025 02:43
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking Identifies a breaking change. enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Make batch ingestion automatic, not a parameter on _bulk
2 participants