-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix match query on a scaled_float property no longer matches for some values #17879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e8f0619
to
40380fb
Compare
❌ Gradle check result for 40380fb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
40380fb
to
adbf317
Compare
❌ Gradle check result for adbf317: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 7a2fa3f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2ba7c47
to
ade3cae
Compare
❌ Gradle check result for 66bb50e: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock #14289 |
@bowenlan-amzn would you mind have a look in your spare time, very thank you. |
66bb50e
to
75cea4e
Compare
❌ Gradle check result for 75cea4e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
75cea4e
to
88bcdda
Compare
❌ Gradle check result for 88bcdda: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
EhCacheDiskCacheTests.testComputeIfAbsentConcurrently #16159 |
❌ Gradle check result for b1a19aa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
… values Signed-off-by: kkewwei <[email protected]> Signed-off-by: kkewwei <[email protected]>
b1a19aa
to
b36c641
Compare
❌ Gradle check result for b36c641: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b36c641: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
RemoteStorePinnedTimestampsGarbageCollectionIT.testLiveIndexNoPinnedTimestampsWithExtraGenSetting #16088 |
This PR is stalled because it has been open for 30 days with no activity. |
Description
This PR only addresses the mismatch issue.
As it's known,
float
anddouble
types suffer from precision loss, and it's inevitable. When readingdoc_value
in the filed(such as range, sorting, or aggregation), it can lead to unforeseen exceptions. The root cause lies in the fact that the precision of float/double data is already lost before storing.OpenSearch/modules/mapper-extras/src/main/java/org/opensearch/index/mapper/ScaledFloatFieldMapper.java
Line 468 in 9db5e67
It can be extremely terrifying when related to money.
To solve it, I will submit a new PR. In this PR, I will create a new type
big_decimal
, supported by BigDecimal to effectively eliminate the precision loss.Related Issues
Resolves #12433
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.