Skip to content

Fix flaky test BoolQueryBuilderTests.testToQuery #17944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

guojialiang92
Copy link
Contributor

Description

This PR is trying to fix a flakey test org.opensearch.index.query.BoolQueryBuilderTests.testToQuery.

Related Issues

Resolves #[17943]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 4a6ceb0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@guojialiang92 guojialiang92 force-pushed the dev/fix_BoolQueryBuilderTests_testToQuery branch from 4a6ceb0 to 40b3e60 Compare April 15, 2025 07:50
Copy link
Contributor

❌ Gradle check result for 40b3e60: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@guojialiang92 guojialiang92 force-pushed the dev/fix_BoolQueryBuilderTests_testToQuery branch from 40b3e60 to 7f8b331 Compare April 15, 2025 08:50
Copy link
Contributor

❌ Gradle check result for 7f8b331: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@guojialiang92 guojialiang92 force-pushed the dev/fix_BoolQueryBuilderTests_testToQuery branch from 7f8b331 to 445951d Compare April 15, 2025 10:04
Copy link
Contributor

❕ Gradle check result for 445951d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.58%. Comparing base (5799fe7) to head (445951d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #17944   +/-   ##
=========================================
  Coverage     72.57%   72.58%           
- Complexity    67066    67083   +17     
=========================================
  Files          5470     5470           
  Lines        309697   309770   +73     
  Branches      45045    45056   +11     
=========================================
+ Hits         224776   224858   +82     
+ Misses        66602    66504   -98     
- Partials      18319    18408   +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@harshavamsi harshavamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @guojialiang92 !

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guojialiang92 for the fix!

@owaiskazi19 owaiskazi19 merged commit f1a8d0e into opensearch-project:main Apr 15, 2025
34 of 36 checks passed
@guojialiang92 guojialiang92 deleted the dev/fix_BoolQueryBuilderTests_testToQuery branch April 16, 2025 02:41
x-INFiN1TY-x pushed a commit to x-INFiN1TY-x/OpenSearch_Local that referenced this pull request Apr 24, 2025
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants