Skip to content

Use test-retry plugin in place of develocity #17976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

andrross
Copy link
Member

To fix the deprecation warnings in #13942 I believe I should have just removed the gradle enterprise plugin all together as I think it is unused. This commit goes back to using the open-source test-retry Gradle plugin and removes develocity.

This should not change the functionality of the test retry logic in any way.

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

To fix the deprecation warnings in opensearch-project#13942 I believe I should have just removed
the gradle enterprise plugin all together as I think it is unused. This commit
goes back to using the open-source test-retry Gradle plugin and removes
develocity.

This should not change the functionality of the test retry logic in any way.

Signed-off-by: Andrew Ross <[email protected]>
@prudhvigodithi
Copy link
Member

Thanks @andrross, once this PR is merged I will update #17939 to focus on the tests re-try side of changes.
Thanks

Copy link
Contributor

❌ Gradle check result for dfcda55: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for dfcda55: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for dfcda55: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for dfcda55: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for dfcda55: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for dfcda55: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for dfcda55: SUCCESS

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.51%. Comparing base (cbaddd3) to head (dfcda55).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17976      +/-   ##
============================================
- Coverage     72.51%   72.51%   -0.01%     
+ Complexity    67108    67035      -73     
============================================
  Files          5475     5475              
  Lines        309916   309916              
  Branches      45060    45060              
============================================
- Hits         224725   224724       -1     
+ Misses        66895    66804      -91     
- Partials      18296    18388      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit 3a7d8fa into opensearch-project:main Apr 17, 2025
58 checks passed
@andrross andrross deleted the test-retry-plugin branch April 17, 2025 19:57
x-INFiN1TY-x pushed a commit to x-INFiN1TY-x/OpenSearch_Local that referenced this pull request Apr 24, 2025
To fix the deprecation warnings in opensearch-project#13942 I believe I should have just removed
the gradle enterprise plugin all together as I think it is unused. This commit
goes back to using the open-source test-retry Gradle plugin and removes
develocity.

This should not change the functionality of the test retry logic in any way.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Tanishq Ranjan <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
To fix the deprecation warnings in opensearch-project#13942 I believe I should have just removed
the gradle enterprise plugin all together as I think it is unused. This commit
goes back to using the open-source test-retry Gradle plugin and removes
develocity.

This should not change the functionality of the test retry logic in any way.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
To fix the deprecation warnings in opensearch-project#13942 I believe I should have just removed
the gradle enterprise plugin all together as I think it is unused. This commit
goes back to using the open-source test-retry Gradle plugin and removes
develocity.

This should not change the functionality of the test retry logic in any way.

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: Harsh Kothari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants