Skip to content

[Pull-based ingestion] Emit lag metric for pull-based ingestion poller #17977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025

Conversation

yupeng9
Copy link
Contributor

@yupeng9 yupeng9 commented Apr 16, 2025

Description

Emit lag metric for pull-based ingestion poller

Also update the API of message to return the timestamp of the message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 8934cb8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7763c5b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7763c5b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7133033: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@yupeng9 yupeng9 closed this Apr 18, 2025
@yupeng9 yupeng9 reopened this Apr 18, 2025
Copy link
Contributor

❌ Gradle check result for 7133033: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for dd41a8b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for dd41a8b: SUCCESS

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.47%. Comparing base (54e02a7) to head (46dd86f).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...rch/indices/pollingingest/DefaultStreamPoller.java 25.00% 2 Missing and 1 partial ⚠️
...pensearch/plugin/kinesis/KinesisShardConsumer.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main   #17977   +/-   ##
=========================================
  Coverage     72.47%   72.47%           
- Complexity    67034    67086   +52     
=========================================
  Files          5478     5478           
  Lines        310132   310155   +23     
  Branches      45087    45092    +5     
=========================================
+ Hits         224775   224792   +17     
- Misses        66960    67023   +63     
+ Partials      18397    18340   -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mch2 mch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, small changelog format typo

yupeng9 added 3 commits April 23, 2025 22:07
Signed-off-by: Yupeng Fu <[email protected]>
Signed-off-by: Yupeng Fu <[email protected]>
Copy link
Contributor

✅ Gradle check result for 46dd86f: SUCCESS

@mch2 mch2 merged commit b32fcef into opensearch-project:main Apr 24, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants