Skip to content

Remove tests for legacy keystore format #18154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

andrross
Copy link
Member

These tests have been disabled for over 4 years.

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for dd30900: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

These tests have been disabled for over 4 years.

Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross force-pushed the remove-tests-for-legacy-keystore branch from dd30900 to 70be938 Compare April 30, 2025 00:43
Copy link
Contributor

❌ Gradle check result for 70be938: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 70be938: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 70be938: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 70be938: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 70be938: SUCCESS

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.53%. Comparing base (a6724d3) to head (70be938).
Report is 80 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #18154   +/-   ##
=========================================
  Coverage     72.53%   72.53%           
+ Complexity    67207    67148   -59     
=========================================
  Files          5476     5476           
  Lines        310436   310437    +1     
  Branches      45121    45121           
=========================================
+ Hits         225179   225182    +3     
+ Misses        66894    66832   -62     
- Partials      18363    18423   +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cwperks cwperks merged commit 8439478 into opensearch-project:main May 20, 2025
30 checks passed
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Jun 1, 2025
These tests have been disabled for over 4 years.

Signed-off-by: Andrew Ross <[email protected]>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
These tests have been disabled for over 4 years.

Signed-off-by: Andrew Ross <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
These tests have been disabled for over 4 years.

Signed-off-by: Andrew Ross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants