Reduce runtime of PitMultiNodeIT by 6 minutes #18167
Conversation
This commit reduces the runtime of the test from over 6 minutes to about 10 seconds. The current code attempts to do a flush after a node has dropped, resulting in waiting on the [replication timeout][1] of 1 minute. The change here is to ensure the flush happens before any nodes are stopped. [1]: https://github.com/opensearch-project/OpenSearch/blob/7977446398fda5d553f39e2db32a395e917b9c78/server/src/main/java/org/opensearch/action/support/replication/ReplicationRequest.java#L64 Signed-off-by: Andrew Ross <[email protected]>
andrross
requested review from
anasalkouz,
ashking94,
Bukhtawar,
CEHENKLE,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah and
a team
as code owners
|
❌ Gradle check result for 2fecfbf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 2fecfbf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 2fecfbf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18167 +/- ##
============================================
- Coverage 72.53% 72.52% -0.02%
- Complexity 67207 67250 +43
============================================
Files 5476 5476
Lines 310436 310437 +1
Branches 45121 45121
============================================
- Hits 225179 225142 -37
- Misses 66894 67002 +108
+ Partials 18363 18293 -70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This commit reduces the runtime of the test from over 6 minutes to about 10 seconds. The current code attempts to do a flush after a node has dropped, resulting in waiting on the replication timeout of 1 minute. The change here is to ensure the flush happens before any nodes are stopped.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.