Fail fast if initial delete call fails in CreateIndexIT #18169
Conversation
|
❌ Gradle check result for bfd17e1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18169 +/- ##
============================================
+ Coverage 72.58% 72.67% +0.09%
- Complexity 67219 67342 +123
============================================
Files 5476 5476
Lines 310445 310445
Branches 45121 45121
============================================
+ Hits 225324 225630 +306
+ Misses 66780 66424 -356
- Partials 18341 18391 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Previously if the delete call failed then the test would block indefinitely on the latch as nothing would count it down. The test would then hit the overall timeout and report thread leak failures. This change captures the exception and fails immediately in the test thread if the delete call fails. Signed-off-by: Andrew Ross <[email protected]>
andrross
force-pushed
the
create-index-it-delete-failure
branch
from
bfd17e1 to
4a7ffc8
Compare
...r/src/internalClusterTest/java/org/opensearch/action/admin/indices/create/CreateIndexIT.java
Show resolved
Hide resolved
|
❌ Gradle check result for 4a7ffc8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 4a7ffc8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Previously if the delete call failed then the test would block indefinitely on the latch as nothing would count it down. The test would then hit the overall timeout and report thread leak failures. This change captures the exception and fails immediately in the test thread if the delete call fails.
I'm not totally sure this is where the test is occasionally failing, but here is a case where the overall test timeout was reached: #14312 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.