Fix flaky pull-based ingestion tests #18216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Bharadwaj <[email protected]>
github-actions
bot
added
>test-failure
|
❕ Gradle check result for 6a459b8: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18216 +/- ##
============================================
+ Coverage 72.52% 72.62% +0.09%
- Complexity 67228 67300 +72
============================================
Files 5476 5476
Lines 310470 310470
Branches 45131 45131
============================================
+ Hits 225168 225472 +304
+ Misses 66973 66710 -263
+ Partials 18329 18288 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrross
approved these changes
May 6, 2025
This was referenced May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few pull-based ingestion IT tests are marked flaky. Majority of these are due to timeout errors creating Kafka topic. Though unable to reproduce any of these in local at this time, this PR increases the wait time for topic creation. Also adds a check in pause/resume API call to make sure pause/resume is complete before proceeding. This PR will be merged and observe for further reported flaky tests, if any.
Related Issues
Resolves #17693
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.