Created RemoteUploadeService and performed the code changes #18344
Conversation
|
❌ Gradle check result for 19cd067: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1746bfa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 1de77c9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for dd93d27: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 93b2ba2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 8be9c7e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
| shards.assertAllEqual(numDocs + moreDocs); | ||
| } | ||
| } | ||
| // public void testNoTranslogHistoryTransferred() throws Exception { |
There was a problem hiding this comment.
This test shouldn't be commented out
| /** | ||
| * RemoteUploaderService for uploading the files to remote store. | ||
| */ | ||
| public class RemoteUploaderService { |
There was a problem hiding this comment.
Can we define an under abstract interface for this? The interface should have methods like the following:
syncSegmentssyncSegmentsAsync
Depending on the who the caller is, there can be multiple implementations for that interface.
@ashking94 wdyt?
| @@ -4079,12 +4080,21 @@ private EngineConfig newEngineConfig(LongSupplier globalCheckpointSupplier) thro | |||
| } | |||
|
|
|||
| if (isRemoteStoreEnabled() || isMigratingToRemote()) { | |||
|
|
|||
| final RemoteUploaderService remoteUploaderService = new RemoteUploaderService( | |||
There was a problem hiding this comment.
Define this as a singletone maybe?
|
❌ Gradle check result for 3b5852b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.