-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Ability to run Code Coverage locally with Gradle #18509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Prudhvi Godithi <[email protected]>
Adding @andrross @reta @cwperks @getsaurabh02 |
🙌 Thank you Prudvhi! CC: @beanuwave |
05ceb15
to
35b2d9b
Compare
Coming from https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/gradle/gradle-check.jenkinsfile#L154 I'm also testing locally to see if |
Can we add a CHANGELOG entry? Even if this is a developer centric PR I think its worth noting in the release notes that jacoco reports can now be produced locally. |
Sure let me do that |
35b2d9b
to
22bc43d
Compare
❌ Gradle check result for 22bc43d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 22bc43d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
22bc43d
to
9d214af
Compare
9d214af
to
177b891
Compare
Signed-off-by: Prudhvi Godithi <[email protected]>
177b891
to
1903747
Compare
❌ Gradle check result for 1903747: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 1903747: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Prudhvi Godithi <[email protected]>
❌ Gradle check result for 3b58396: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3b58396: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18509 +/- ##
============================================
+ Coverage 72.64% 72.80% +0.16%
- Complexity 68070 68171 +101
============================================
Files 5537 5537
Lines 313404 313404
Branches 45476 45476
============================================
+ Hits 227658 228165 +507
+ Misses 67241 66728 -513
- Partials 18505 18511 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Coming from https://app.codecov.io/gh/opensearch-project/OpenSearch/tree/main/qa%2Fdie-with-dignity%2Fsrc%2Fmain%2Fjava%2Forg%2Fopensearch I can no see some coverage of |
…18509) * Project Code Coverage Signed-off-by: Prudhvi Godithi <[email protected]> * Project Code Coverage Signed-off-by: Prudhvi Godithi <[email protected]> * Update gradle logic Signed-off-by: Prudhvi Godithi <[email protected]> --------- Signed-off-by: Prudhvi Godithi <[email protected]>
…18509) * Project Code Coverage Signed-off-by: Prudhvi Godithi <[email protected]> * Project Code Coverage Signed-off-by: Prudhvi Godithi <[email protected]> * Update gradle logic Signed-off-by: Prudhvi Godithi <[email protected]> --------- Signed-off-by: Prudhvi Godithi <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
…18509) * Project Code Coverage Signed-off-by: Prudhvi Godithi <[email protected]> * Project Code Coverage Signed-off-by: Prudhvi Godithi <[email protected]> * Update gradle logic Signed-off-by: Prudhvi Godithi <[email protected]> --------- Signed-off-by: Prudhvi Godithi <[email protected]>
Description
Related Issues
While I'm working on this PR #18358, I noticed that GitHub reports code coverage only after the Gradle Check workflow passes. Being able to run coverage reports locally using Gradle can help test and improve coverage earlier in the development cycle. Although IntelliJ provides some insights, using Gradle with the JaCoCo plugin ensures consistency with the coverage reported by GitHub.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.