-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Remove clone holder and add Cleaner logic to clean up clones in FullFileCachedIndexInput #18662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove clone holder and add Cleaner logic to clean up clones in FullFileCachedIndexInput #18662
Conversation
❌ Gradle check result for b6f1d31: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for be9167a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…ileCachedIndexInput Signed-off-by: Shreyansh Ray <[email protected]>
Signed-off-by: Shreyansh Ray <[email protected]>
546b4ad
to
419f60d
Compare
❌ Gradle check result for 419f60d: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/store/remote/filecache/FullFileCachedIndexInput.java
Show resolved
Hide resolved
Signed-off-by: Shreyansh Ray <[email protected]>
419f60d
to
88fbd2a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18662 +/- ##
============================================
- Coverage 72.80% 72.76% -0.04%
+ Complexity 68437 68397 -40
============================================
Files 5563 5563
Lines 314174 314179 +5
Branches 45554 45555 +1
============================================
- Hits 228726 228612 -114
- Misses 66871 66975 +104
- Partials 18577 18592 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Remove clone holder and add Cleaner logic to clean up clones in FullFileCachedIndexInput
Related Issues
Resolves #18659
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.