Skip to content

Remove clone holder and add Cleaner logic to clean up clones in FullFileCachedIndexInput #18662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 4, 2025

Conversation

rayshrey
Copy link
Contributor

@rayshrey rayshrey commented Jul 1, 2025

Description

Remove clone holder and add Cleaner logic to clean up clones in FullFileCachedIndexInput

Related Issues

Resolves #18659

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jul 1, 2025

❌ Gradle check result for b6f1d31: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jul 1, 2025

❌ Gradle check result for be9167a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rayshrey rayshrey force-pushed the fullFileIndexInputCleaner branch from 546b4ad to 419f60d Compare July 1, 2025 20:15
Copy link
Contributor

github-actions bot commented Jul 1, 2025

❌ Gradle check result for 419f60d:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shreyansh Ray <[email protected]>
@rayshrey rayshrey force-pushed the fullFileIndexInputCleaner branch from 419f60d to 88fbd2a Compare July 4, 2025 03:53
Copy link
Contributor

github-actions bot commented Jul 4, 2025

✅ Gradle check result for 88fbd2a: SUCCESS

Copy link

codecov bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.76%. Comparing base (0874e58) to head (88fbd2a).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...ore/remote/filecache/FullFileCachedIndexInput.java 86.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18662      +/-   ##
============================================
- Coverage     72.80%   72.76%   -0.04%     
+ Complexity    68437    68397      -40     
============================================
  Files          5563     5563              
  Lines        314174   314179       +5     
  Branches      45554    45555       +1     
============================================
- Hits         228726   228612     -114     
- Misses        66871    66975     +104     
- Partials      18577    18592      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this to 👀 In review in Storage Project Board Jul 4, 2025
@gbbafna gbbafna merged commit 5d9695c into opensearch-project:main Jul 4, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Storage Project Board Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[BUG] Writable Warm - FullFileCachedIndexInput Clone map can cause memory explosion
2 participants