Prevent derived source from open reader per transform #2652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmazanec15
added
Bug Fixes
jmazanec15
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng,
shatejas,
0ctopus13prime and
Vikasht34
as code owners
jmazanec15
force-pushed
the
derived-dup-fix
branch
from
5ea6a7d to
c2d6ab3
Compare
...org/opensearch/knn/index/codec/backward_codecs/KNN9120Codec/KNN9120DerivedSourceReaders.java
Outdated
Show resolved
Hide resolved
jmazanec15
force-pushed
the
derived-dup-fix
branch
3 times, most recently
from
b2a5fc7 to
e23b7f2
Compare
0ctopus13prime
previously approved these changes
Apr 9, 2025
jmazanec15
force-pushed
the
derived-dup-fix
branch
from
e23b7f2 to
22c4f66
Compare
0ctopus13prime
previously approved these changes
Apr 9, 2025
shatejas
previously approved these changes
Apr 9, 2025
jmazanec15
force-pushed
the
derived-dup-fix
branch
2 times, most recently
from
11dec2e to
947204a
Compare
shatejas
approved these changes
Apr 9, 2025
0ctopus13prime
approved these changes
Apr 9, 2025
|
@jmazanec15 #2657 to fix the builds, ty |
jmazanec15
force-pushed
the
derived-dup-fix
branch
from
947204a to
fec0673
Compare
Fixes a bug that was already fixed in opensearch-project#2494 but was then reverted by accident in a refactor. It makes it so that instead of opening up readers for each transform request, it opens up once per reader. Signed-off-by: John Mazanec <[email protected]>
jmazanec15
force-pushed
the
derived-dup-fix
branch
from
fec0673 to
9566636
Compare
oaganesh
pushed a commit
to oaganesh/k-NN
that referenced
this pull request
Apr 24, 2025
…ject#2652) Fixes a bug that was already fixed in opensearch-project#2494 but was then reverted by accident in a refactor. It makes it so that instead of opening up readers for each transform request, it opens up once per reader. Signed-off-by: John Mazanec <[email protected]>
oaganesh
added a commit
to oaganesh/k-NN
that referenced
this pull request
Apr 29, 2025
…arch-project#2652)" This reverts commit 105b970.
luyuncheng
pushed a commit
to luyuncheng/k-NN-1
that referenced
this pull request
Jun 18, 2025
…ject#2652) Fixes a bug that was already fixed in opensearch-project#2494 but was then reverted by accident in a refactor. It makes it so that instead of opening up readers for each transform request, it opens up once per reader. Signed-off-by: John Mazanec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug that was already fixed in #2494 but was then reverted by accident in a refactor. It makes it so that instead of opening up readers for each transform request, it opens up once per reader.
This was caught in a 100M perf test I was running. Im thinking we should maybe upgrade our nightlies to use this to prevent in future.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.