Skip to content

Update highlighting model translator to adapt new model #3699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Apr 2, 2025

Description

Update highlighting QA model to adapt new highlighter model:

  • Add chunk strategy due to model max length limitation to 512 by default
  • Introduced sentence_ids which is required by new model

Related Issues

opensearch-project/neural-search#1182

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@junqiu-lei junqiu-lei self-assigned this Apr 2, 2025
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 2, 2025 01:27 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 2, 2025 01:27 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 2, 2025 01:27 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 2, 2025 01:27 — with GitHub Actions Inactive
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 84.23645% with 32 lines in your changes missing coverage. Please review.

Project coverage is 80.30%. Comparing base (b9d5201) to head (39114b4).

Files with missing lines Patch % Lines
...on_answering/SentenceHighlightingQATranslator.java 77.23% 18 Missing and 10 partials ⚠️
...hms/question_answering/QuestionAnsweringModel.java 94.73% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3699      +/-   ##
============================================
+ Coverage     80.27%   80.30%   +0.02%     
- Complexity     7054     7090      +36     
============================================
  Files           621      621              
  Lines         30801    30939     +138     
  Branches       3470     3496      +26     
============================================
+ Hits          24726    24845     +119     
- Misses         4567     4579      +12     
- Partials       1508     1515       +7     
Flag Coverage Δ
ml-commons 80.30% <84.23%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@junqiu-lei junqiu-lei had a problem deploying to ml-commons-cicd-env-require-approval April 2, 2025 03:06 — with GitHub Actions Failure
@junqiu-lei junqiu-lei had a problem deploying to ml-commons-cicd-env-require-approval April 2, 2025 03:06 — with GitHub Actions Failure
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 2, 2025 22:27 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei had a problem deploying to ml-commons-cicd-env-require-approval April 2, 2025 22:27 — with GitHub Actions Failure
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 2, 2025 22:27 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei had a problem deploying to ml-commons-cicd-env-require-approval April 2, 2025 22:27 — with GitHub Actions Error
@junqiu-lei junqiu-lei had a problem deploying to ml-commons-cicd-env-require-approval April 2, 2025 23:54 — with GitHub Actions Failure
Signed-off-by: Junqiu Lei <[email protected]>
@junqiu-lei junqiu-lei requested review from dhrubo-os and mingshl April 8, 2025 17:25
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 8, 2025 17:26 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 8, 2025 17:26 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 8, 2025 17:26 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 8, 2025 17:26 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 8, 2025 19:28 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 8, 2025 19:28 — with GitHub Actions Inactive
Signed-off-by: Junqiu Lei <[email protected]>
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 8, 2025 21:16 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei temporarily deployed to ml-commons-cicd-env-require-approval April 8, 2025 21:16 — with GitHub Actions Inactive
@junqiu-lei junqiu-lei had a problem deploying to ml-commons-cicd-env-require-approval April 8, 2025 21:16 — with GitHub Actions Failure
@junqiu-lei junqiu-lei had a problem deploying to ml-commons-cicd-env-require-approval April 8, 2025 21:16 — with GitHub Actions Error
@junqiu-lei junqiu-lei requested review from dhrubo-os and mingshl April 8, 2025 21:57
@mingshl mingshl merged commit 82da998 into opensearch-project:main Apr 8, 2025
8 of 10 checks passed
@mingshl
Copy link
Collaborator

mingshl commented Apr 8, 2025

@junqiu-lei please create new issue and add the new doc for documentation repo to introduce this new model https://github.com/opensearch-project/documentation-website

@junqiu-lei
Copy link
Member Author

junqiu-lei commented Apr 8, 2025

Great thanks @mingshl, @dhrubo-os and @akolarkunnu for the reviewing.

@junqiu-lei please create new issue and add the new doc for documentation repo to introduce this new model https://github.com/opensearch-project/documentation-website

Yes, working on it by opensearch-project/documentation-website#9583

akolarkunnu pushed a commit to akolarkunnu/ml-commons that referenced this pull request Jun 6, 2025
…roject#3699)

* Update highlighting model translator to adapt new model

Signed-off-by: Junqiu Lei <[email protected]>

* Resolve PR feedback

Signed-off-by: Junqiu Lei <[email protected]>

* Resolve PR feedback 2

Signed-off-by: Junqiu Lei <[email protected]>

* Resolve PR feedback 3

Signed-off-by: Junqiu Lei <[email protected]>

---------

Signed-off-by: Junqiu Lei <[email protected]>
Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants