-
Notifications
You must be signed in to change notification settings - Fork 165
Update highlighting model translator to adapt new model #3699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
613343b
to
48df4bb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3699 +/- ##
============================================
+ Coverage 80.27% 80.30% +0.02%
- Complexity 7054 7090 +36
============================================
Files 621 621
Lines 30801 30939 +138
Branches 3470 3496 +26
============================================
+ Hits 24726 24845 +119
- Misses 4567 4579 +12
- Partials 1508 1515 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
48df4bb
to
7fc77db
Compare
7fc77db
to
3535f70
Compare
Signed-off-by: Junqiu Lei <[email protected]>
02780be
to
39114b4
Compare
...main/java/org/opensearch/ml/engine/algorithms/question_answering/QuestionAnsweringModel.java
Show resolved
Hide resolved
...org/opensearch/ml/engine/algorithms/question_answering/SentenceHighlightingQATranslator.java
Outdated
Show resolved
Hide resolved
...main/java/org/opensearch/ml/engine/algorithms/question_answering/QuestionAnsweringModel.java
Show resolved
Hide resolved
...org/opensearch/ml/engine/algorithms/question_answering/SentenceHighlightingQATranslator.java
Show resolved
Hide resolved
.../org/opensearch/ml/engine/algorithms/question_answering/SentenceHighlightingQAModelTest.java
Show resolved
Hide resolved
...org/opensearch/ml/engine/algorithms/question_answering/SentenceHighlightingQATranslator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Junqiu Lei <[email protected]>
@junqiu-lei please create new issue and add the new doc for documentation repo to introduce this new model https://github.com/opensearch-project/documentation-website |
Great thanks @mingshl, @dhrubo-os and @akolarkunnu for the reviewing.
Yes, working on it by opensearch-project/documentation-website#9583 |
…roject#3699) * Update highlighting model translator to adapt new model Signed-off-by: Junqiu Lei <[email protected]> * Resolve PR feedback Signed-off-by: Junqiu Lei <[email protected]> * Resolve PR feedback 2 Signed-off-by: Junqiu Lei <[email protected]> * Resolve PR feedback 3 Signed-off-by: Junqiu Lei <[email protected]> --------- Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: Abdul Muneer Kolarkunnu <[email protected]>
Description
Update highlighting QA model to adapt new highlighter model:
sentence_ids
which is required by new modelRelated Issues
opensearch-project/neural-search#1182
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.