Skip to content

[PROPOSAL] Clean up unnecessary feature flag #1226

Open
@bzhangam

Description

@bzhangam

What/Why

What are you proposing?

Clean up the unnecessary feature flag NEURAL_SEARCH_HYBRID_SEARCH_DISABLED.

It's not needed anymore so we should remove it to keep the code clean.

Besides it's being used in a wrong way that we will always return false when we check it. We collect settings defined by the plugins and register them after we initialize the feature flag in core. Which means it will not be added to the FeatureFlag and later when we check it we will always use the default value false.

What users have asked for this feature?

N/A

What problems are you trying to solve?

Clean up the code and avoid potential bugs.

What is the developer experience going to be?

N/A

Are there any security considerations?

N/A

Are there any breaking changes to the API

N/A

What is the user experience going to be?

N/A

Are there breaking changes to the User Experience?

N/A

Why should it be built? Any reason not to?

N/A

What will it take to execute?

Simple code change to clean it up.

Any remaining open questions?

N/A

Metadata

Metadata

Assignees

Labels

backlogAll the backlog features should be marked with this label

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions