Skip to content

Add remote-index-build-client dependency for k-NN #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Mar 18, 2025

Description

Fix build failure by adding remote-index-build-client dependency for k-NN opensearch-project/k-NN#2603.

Related Issues

Resolves #1232

Check List

  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.70%. Comparing base (57124dd) to head (27d4831).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1233      +/-   ##
============================================
- Coverage     81.83%   81.70%   -0.13%     
+ Complexity     2607     1302    -1305     
============================================
  Files           190       95      -95     
  Lines          8922     4461    -4461     
  Branches       1520      760     -760     
============================================
- Hits           7301     3645    -3656     
+ Misses         1028      522     -506     
+ Partials        593      294     -299     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@junqiu-lei junqiu-lei merged commit 6163f67 into opensearch-project:main Mar 18, 2025
69 of 72 checks passed
ryanbogan pushed a commit to ryanbogan/neural-search that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build failure] Plugin build failed due to k-NN remote index client module change
3 participants