Skip to content

Support phasing off SecurityManager usage in favor of Java Agent #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Apr 14, 2025

Description

Support phasing off SecurityManager usage in favor of Java Agent

This commit allows passing a JVM argument to allow plugins test execute under Java Agent.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks
Copy link
Member Author

cwperks commented Apr 14, 2025

I think the additional build issues are related to opensearch-project/OpenSearch@1628152

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
@cwperks cwperks changed the title WIP on neural search testing with java agent Support phasing off SecurityManager usage in favor of Java Agent Apr 15, 2025
@cwperks cwperks marked this pull request as ready for review April 15, 2025 04:35
@cwperks
Copy link
Member Author

cwperks commented Apr 15, 2025

Checks are passing.

@cwperks
Copy link
Member Author

cwperks commented Apr 15, 2025

Closing in favor of #1265

@cwperks cwperks closed this Apr 15, 2025
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (5f2fbb4) to head (d75f6a0).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #1267       +/-   ##
============================================
- Coverage     81.34%       0   -81.35%     
============================================
  Files           127       0      -127     
  Lines          5672       0     -5672     
  Branches        916       0      -916     
============================================
- Hits           4614       0     -4614     
+ Misses          702       0      -702     
+ Partials        356       0      -356     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants