Fix BuildManifestBuilder.append_artifact to safely initialize artifact lists #5525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravindkesavan
requested review from
peterzhuamazon,
gaiksaya and
rishabh6788
as code owners
aravindkesavan
requested review from
zelinh,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
…t lists Signed-off-by: Aravindan A <[email protected]>
aravindkesavan
force-pushed
the
fix-artifacts-list-initialization
branch
from
b3c934c to
2999814
Compare
|
Hi @aravindkesavan , Thanks for PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This change fixes a bug in the BuildManifestBuilder.append_artifact method where the artifact list was not safely initialized. Previously, the code retrieved the list using artifacts.get(type, []) but did not always assign the empty list back to the dictionary, which could lead to cases where the list was not properly stored or updated.
The fix ensures that if the artifact type key does not exist or is not a list, an empty list is explicitly assigned before appending the new artifact path.
Issues Resolved
No specific issue number was referenced, but this fix improves the stability of the build manifest creation logic.
Note: Fixes initialization of artifact lists in BuildManifestBuilder.append_artifact. Ensures the artifact type key always holds a list before appending, preventing potential errors during build manifest creation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.